Uploaded image for project: 'Pegasus'
  1. Pegasus
  2. PM-1508

in the python api, the method signature to manually add dependencies needs to be updated

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: master, 5.0.0
    • Fix Version/s: master, 5.0.0
    • Component/s: None
    • Labels:
      None

      Description

      In the python api, we currently have:

      Workflow.add_dependency(parent, *children),

      However, when manually adding dependencies, it can be confusing for some users because it is not clear whether or not parent ->children or child->parents are being added. To be more explicit, we have decided to change the above method signature to Workflow.add_dependency(node, *, parents=[], children=[]).
      (based on 4/13 dev meeting: https://docs.google.com/document/d/1URPG6SLG481Y7DDAajjVtedKjS5pwIQ41UOhwSQYbhk/edit#bookmark=id.e65cnw94oy1y)

        Attachments

          Activity

            People

            • Assignee:
              tanaka Ryan Tanaka
              Reporter:
              tanaka Ryan Tanaka
            • Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: